Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure the following before submitting a PR:
Issues 6 and 7.
/Rnot/manand rundevtools::document()to update documentation/testsfor any new functionality or bug fixR CMD checkruns without error before submitting the PRThe replyto issue, #6, is fixed in sendemail.R at lines 108-111.
The other changes in the two files have to do with issue 7. I fix this issue by allowing the user to enter key, secret, region, and force_credentials = TRUE in the send_email() function. The region in this case is the region of the AWS SES server, which, in the long run, is unlikely to be the region of the user's instance. I also added a bit to the Details about how to get the needed key and secret from AWS.
The fix also involves putting an if() statement around the locate_credentials call in http.R so that the user's credentials aren't over-written when force_credentials = TRUE and so that the region parameter in send_email() remains the SES region, not the instance region.
As an added side-effect, with these changes aws.ses allows a user with the proper credentials to send email from any computer, not just an instance on AWS.